Bug / footgun calling slice.delete()

[Sunjay Cauligi]

If you call slice.delete() on a slice that hasn’t been submitted yet, then fablib deletes all of your slices.

Discovered due to seemingly-benign code I was running like so:

try:
  slice = fablib.new_slice(name="test")
  # ... add nodes/networks to slice ...
  slice.submit()
except:
  slice.delete()

It seems to be because the slice object’s .sm_slice field is set to None, which is treated by one of the underlying APIs as denoting “delete all” instead of “unknown slice”.

[Komal Thareja]

Thank you for sharing this Sunjay, we will fix this in the next version.

Thanks,

Komal

[Author]

Posts